Merged
Conversation
louismaximepiton
force-pushed
the
ouds/main-his-btn-comp
branch
from
a2fd86c to
9d00d23
Compare
nilloq
force-pushed
the
ouds/main-sc-navigation-links
branch
from
692f3e8 to
034d6d0
Compare
Member
There was a problem hiding this comment.
Probably not the final review.
- I think I messed up with the
// OUDS modcomments, need to recheck all those. - It's probably missing the migration guides before merging.
- I haven't checked all the occurrences of links in the doc.
- Do we handle redirections to the last versions of
/utilities/linkand/helpers/icon-link? - I haven't spend much time to investigate the different variants of the links when being standalone.
nilloq
force-pushed
the
ouds/main-sc-navigation-links
branch
from
d256e57 to
0a043a0
Compare
louismaximepiton
force-pushed
the
ouds/main-sc-navigation-links
branch
from
378e9cd to
48fc2cc
Compare
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
PR Overview
This PR introduces a new link component and updates related documentation to align with the redesigned default link styles, while cleaning up outdated files and examples. Key changes include:
- The addition of a new components documentation page (links.md) with examples on base, chevron, and icon links.
- Updates to the reboot documentation to reflect disabled and visited link styles.
- Adjustments to the sidebar and typography docs by removing legacy or commented-out link information.
Reviewed Changes
| File | Description |
|---|---|
| site/content/docs/0.1/components/links.md | New documentation with examples for the reusable link component styles and variants. |
| site/content/docs/0.1/content/reboot.md | Updated examples to demonstrate disabled link styling and visited link handling. |
| site/data/sidebar.yml | Updated sidebar to include new Links entries and removal of outdated link topics. |
| site/content/docs/0.1/content/typography.md | Removed obsolete commented sections regarding links to streamline documentation. |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
site/content/docs/0.1/components/links.md:4
- [nitpick] The word 'customer' appears to be a typo; if the intended meaning is to describe tailored or custom link styles, consider correcting it to 'custom'.
description: Use OUDS Web's customer link styles for links as a key navigational element, enabling users to move between pages, sections, or external resources.
louismaximepiton
requested changes
Feb 27, 2025
Member
louismaximepiton
left a comment
louismaximepiton
left a comment
There was a problem hiding this comment.
Should we add a pseudo element to increase the tap size ?
I think we can reintroduce .btn-link with the PR as well.
hannahiss
requested changes
Mar 4, 2025
Member
hannahiss
left a comment
hannahiss
left a comment
There was a problem hiding this comment.
Sorry, I have a lot of remarks about doc, I tried to make some propositions... I also saw a few "bugs". I'll be available to explain if needed.
I put here some notes I didn't know where to write:
- Missing
.btn-linkclass to add in buttons page, maybe just in bootstrap compat, and.btn .btn-linkmay look like.link - I feel like something is missing about disabled state: in buttons we explain everything about
aria-disabled, andhref, andtabindex, but here nothing. Maybe this part should be in links and referenced in buttons?
There was a problem hiding this comment.
PR Overview
This PR introduces the new Links component along with updated default link styles, and migrates related documentation to reflect these changes.
- Adds new documentation for the Links component and its variants.
- Updates migration guides to include new Sass variables and announce breaking changes.
- Removes legacy documentation and sidebar entries for deprecated link helpers.
Reviewed Changes
| File | Description |
|---|---|
| site/content/docs/0.2/components/links.md | New documentation for the Links component and its usage variants |
| site/content/docs/0.2/migration.md | Migration guide updated with new Sass variables and breaking changes |
| site/content/docs/0.2/migration-from-boosted.md | Updated migration information reflecting the new Links component |
| site/content/docs/0.2/content/reboot.md | Reboot documentation updated to demonstrate new link styles and disabled state |
| site/content/docs/0.2/components/buttons.md | Reference to the disabled link accessibility warning updated |
| site/data/sidebar.yml | Sidebar updated to remove legacy link entries |
| site/content/docs/0.2/content/typography.md | Removal of obsolete commented-out link documentation |
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
site/content/docs/0.2/migration.md:57
- The Sass variable '$ouds-link-color-content-pressed:' has a trailing colon, which is inconsistent compared to the other variable definitions; please verify if the colon is intended or if a correct value assignment is missing.
<li><code>$ouds-link-color-content-pressed:</code></li>
hannahiss
requested changes
Mar 7, 2025
Member
hannahiss
left a comment
hannahiss
left a comment
There was a problem hiding this comment.
- the visited style should be applied only on visited state
- remove on colored bg variants for standalone links (do we have to make sure it doesn't apply to them? I think so...)
- add an exmaple of on colored bg variants in reboot
- styles on hover : to discuss
- some wording
vprothais
requested changes
Mar 11, 2025
vprothais
requested changes
Mar 11, 2025
vprothais
requested changes
Mar 12, 2025
vprothais
reviewed
Mar 13, 2025
vprothais
approved these changes
Mar 17, 2025
louismaximepiton
approved these changes
Mar 17, 2025
github-project-automation
bot
moved this from In Progress / Draft
to Done
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
#2824
Description
Implement default html link style and a new link component:
Motivation & Context
Base component of the library
Types of change
Live previews